Python 37 support - #32
Conversation
stealthycoin
left a comment
stealthycoin
left a comment
There was a problem hiding this comment.
Looks good to me. Just two small comments. And would be good to integ test it on each version just to make sure.
| } | ||
|
|
||
| def __init__(self, osutils, pip_runner=None): | ||
| def __init__(self, osutils, pip_runner=None, runtime="python2.7"): |
There was a problem hiding this comment.
Defaulting to 2.7 😲 ?
There was a problem hiding this comment.
haha removed the default.
| "python2.7": "cp27mu", | ||
| "python3.6": "cp36m", | ||
| "python3.7": "cp37m" | ||
| }.get(runtime) |
There was a problem hiding this comment.
Is there any way we can ever get here with an unsupported runtime? If so do we want to raise something here like UnsupportedRuntimeError with a property for the runtime value? Or is this impossible, because of the validator? If its impossible I think I'd rather [runtime] so we at least get a very obvious KeyError instead of a None silently sneaking in.
There was a problem hiding this comment.
I ran into this right in our integ test. So it is possible that we will come here with an unsupported runtime.
There was a problem hiding this comment.
Ok yea. I think I like having an explicit error for it. Thoughts?
stealthycoin
left a comment
stealthycoin
left a comment
There was a problem hiding this comment.
Looks good! Ship it contingent on tests passing!
* Python 37 support * Making the ABI selection explicit * Fixing the lambda_abi to a supported list * Making tests work
* Add python3.10 support. * add support for py3.10 * add ci jobs for py3.10 * Fix python3.10 workflows. --------- Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com>
* feat: add python3.10 support (#32) * Add python3.10 support. * add support for py3.10 * add ci jobs for py3.10 * Fix python3.10 workflows. --------- Co-authored-by: Mehmet Nuri Deveci <5735811+mndeveci@users.noreply.github.com> * Update DESIGN.md * update test cases with py310 differences --------- Co-authored-by: Sean O Brien <sean.obrien.2016@mumail.ie>
2 participants
Description of changes:
Lambda supports Python 3.7. Adding support for building Py37 functions in the builder.
Tested this change locally by running integration tests in Python 3.7
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.