Skip to content

Enable esbuild in the Node.js builder - #307

Merged
mildaniel merged 20 commits into
aws:developfrom
mildaniel:esbuild-nodejs-builder
Jan 22, 2022
Merged

Enable esbuild in the Node.js builder#307
mildaniel merged 20 commits into
aws:developfrom
mildaniel:esbuild-nodejs-builder

Conversation

@mildaniel

Copy link
Copy Markdown
Contributor

Taking over the PR from #252. Thank you @gojko for the contribution!

Description from the original PR:

Issue #, if available:

Solves the following issues or makes them obsolete

Description of changes:

Support for ESBuild bundler running as part of the Nodejs NPM workflow, providing the following benefits:

  1. support for local directory dependencies and NPM7 relative references and sym linked node_modules
  2. support for TypeScript transpilation (.ts -> .js)
  3. support for minification (smaller bundle sizes)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@CoshUS
CoshUS self-requested a review November 10, 2021 00:12
@grahamlyons

Copy link
Copy Markdown

Super excited to see this go green.

Comment thread aws_lambda_builders/workflows/nodejs_npm/DESIGN.md
Comment thread aws_lambda_builders/workflows/nodejs_npm/DESIGN.md
Comment thread aws_lambda_builders/workflows/nodejs_npm/actions.py Outdated
Comment thread aws_lambda_builders/workflows/nodejs_npm/actions.py Outdated
Comment thread aws_lambda_builders/workflows/nodejs_npm/esbuild.py Outdated
Comment thread aws_lambda_builders/workflows/nodejs_npm/workflow.py Outdated
Comment thread aws_lambda_builders/workflows/nodejs_npm/workflow.py
Comment thread aws_lambda_builders/workflows/nodejs_npm/workflow.py
@jfuss jfuss mentioned this pull request Nov 23, 2021
@totegi

totegi commented Dec 22, 2021

Copy link
Copy Markdown

This would be really nice

@falnyr

falnyr commented Dec 29, 2021

Copy link
Copy Markdown

@mildaniel any update on this? 🙏

@deepak7panwar

Copy link
Copy Markdown

@mildaniel please finish this!🙏

@mildaniel
mildaniel requested a review from CoshUS January 6, 2022 21:31
Comment thread aws_lambda_builders/workflows/nodejs_npm/DESIGN.md Outdated
Comment thread aws_lambda_builders/workflows/nodejs_npm/esbuild.py
Comment thread aws_lambda_builders/workflows/nodejs_npm/actions.py Outdated
@mildaniel
mildaniel requested a review from hawflau January 11, 2022 17:35

@CoshUS CoshUS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed cases for download_dependencies == false.
Added a full truth table for each possible combination.
Let me know if you have any question.

Comment thread aws_lambda_builders/workflows/nodejs_npm/workflow.py Outdated
Comment thread aws_lambda_builders/workflows/nodejs_npm/workflow.py Outdated
@mildaniel
mildaniel requested a review from CoshUS January 20, 2022 19:30

@CoshUS CoshUS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for addressing the comments!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants