Fix Go debug mode - #232
Merged
Merged
Conversation
prenx4x
approved these changes
Apr 21, 2021
sriram-mv
approved these changes
Apr 22, 2021
aahung
pushed a commit
to aahung/aws-lambda-builders
that referenced
this pull request
May 21, 2021
aahung
pushed a commit
that referenced
this pull request
May 21, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Compiling Go binaries without optimizations was not working. This is because "-gcflags='all=-N -l'" is not actually a valid argument to be passed to the executable. The equal sign should be treated as an argument separator, so a shell would parse this to "-gcflags" and "all=-N -l".
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.