fix: Python Workflow with Incorrect Environ - #223
Merged
Conversation
CoshUS
commented
Feb 19, 2021
| # setup go | ||
| - rmdir c:\go /s /q | ||
| - "choco install golang" | ||
| - "choco install golang --version 1.15.7" |
Contributor
Author
There was a problem hiding this comment.
Pinning down golang version to 1.15 as 1.16 changes default Windows installation directory which breaks AppVeyor.
wchengru
previously approved these changes
Feb 19, 2021
sriram-mv
requested changes
Feb 19, 2021
| # https://pyinstaller.readthedocs.io/en/stable/runtime-information.html#ld-library-path-libpath-considerations | ||
| env = dict(os.environ) | ||
| lp_key = "LD_LIBRARY_PATH" | ||
| original_lp = env.get(lp_key + "_ORIG") |
Contributor
There was a problem hiding this comment.
is this just specific to some systems where LD_LIBRARY_PATH_ORIG is populated? is there any way we can make this very specific to pyinstaller? does pyinstaller re-introduce any other env vars?
Contributor
Author
There was a problem hiding this comment.
LD_LIBRARY_PATH_ORIG is only populated if LD_LIBRARY_PATH is set. There are no other env vars that are generated by PyInstaller. I will add a check to run this only in PyInstaller.
sriram-mv
previously approved these changes
Feb 22, 2021
sriram-mv
left a comment
sriram-mv
left a comment
Contributor
There was a problem hiding this comment.
Looks good, could you clean up the commit history?
CoshUS
force-pushed
the
fix/lb-library-path
branch
from
February 22, 2021 20:32
aa404b5 to
84a59ca
Compare
Contributor
Author
|
Cleaned up merge commits. |
wchengru
approved these changes
Feb 22, 2021
sriram-mv
approved these changes
Feb 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#224
Description of changes:
Patches the LB_LIBRARY_PATH envar and passes the original one to all popens in Python workflow.
This is required as PyInstaller changes LB_LIBRARY_PATH and affects its subprocesses.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.