Prevent already downloaded dependencies from hanging the download - #209
Merged
Conversation
CoshUS
approved these changes
Mar 16, 2021
moelasmar
approved these changes
Mar 26, 2021
aahung
pushed a commit
to aahung/aws-lambda-builders
that referenced
this pull request
May 21, 2021
…s#209) * Prevent already downloaded dependencies from hanging the download process (it's waiting for user input) * Fixed test * Fixed tests * Formatted Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
aahung
pushed a commit
that referenced
this pull request
May 21, 2021
* Prevent already downloaded dependencies from hanging the download process (it's waiting for user input) * Fixed test * Fixed tests * Formatted Co-authored-by: Mohamed Elasmar <71043312+moelasmar@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent already downloaded dependencies from hanging the download process (it's waiting for user input)
Issue #, if available:
Description of changes:
If your build depends on two private repos, for example your
requirements.txthas:and
package_2depends onpackage_1in it's ownrequirements.txt, the build process hangs. It waits for user input, to decide how to deal with the existing downloadedpackage_1. This commit should provide a sensible default behaviour.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.