Added maven dependency flag to include groupIds when copying dependen… - #195
Merged
Conversation
agco-jheerman
approved these changes
Sep 8, 2020
agco-jheerman
left a comment
agco-jheerman
left a comment
There was a problem hiding this comment.
This change looks good to me. We forked this repository and implemented this patch. The solution worked as expected. The jar files copied into the scratch directory contained the group id. The jar files that had previously been overwritten due to duplicate artifact names, were present in the scratch directory. AWS SAM local invoke worked as expected.
|
Any updates on when when should expect to see this fix merged into the main branch? |
CoshUS
approved these changes
Mar 16, 2021
|
Is there any ETA on when we can expect a 2nd review? |
Contributor
Author
|
@CoshUS do you know what needs to be done get another review that counts? |
hoffa
approved these changes
May 3, 2021
aahung
pushed a commit
to aahung/aws-lambda-builders
that referenced
this pull request
May 21, 2021
aws#195) * Added maven dependency flag to include groupIds when copying dependencies * updated java maven dependency test expected results * update java maven unit test Co-authored-by: Cosh_ <CoshUS@users.noreply.github.com>
aahung
pushed a commit
that referenced
this pull request
May 21, 2021
#195) * Added maven dependency flag to include groupIds when copying dependencies * updated java maven dependency test expected results * update java maven unit test Co-authored-by: Cosh_ <CoshUS@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull-request fixes issue #194 by having maven dependency copy-dependencies to include the group id in the file name of all dependency jars
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.