Integration test for python_pip workflow + cleanups. Fixes #14 - #18
Merged
Conversation
sanathkr
changed the title
python_pip workflow + cleanupspython_pip workflow + cleanups. Fixes #14
sanathkr
added a commit
that referenced
this pull request
Nov 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Integration test makes sure it can build with
numpyrequirement. It doesn't actually deploy to Lambda and test. This will be added in future but for now it is simply ensuring the workflow works.I also cleaned up a lot of unused code and fixed linter/flake issues.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.