Repository navigation
feat(telemetry): add the telemetry-4 conformance handler - #924
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
hln33
force-pushed
the
feat/conformance-telemetry-4
branch
from
November 10, 2026 19:09
60cfa99 to
e4fd62b
Compare
This comment has been minimized.
This comment has been minimized.
The telemetry-4 requirement is not on the conformance main branch yet. The e2e run needs it. So this pins the shared workflow to the head of feat/telemetry-4-full-tree-map (c7abf1b). Re-pin to the merge commit once that PR merges.
hln33
force-pushed
the
feat/conformance-telemetry-4
branch
from
November 10, 2026 20:41
e4fd62b to
738180f
Compare
…4 head Conformance PR #185 was stacked on the telemetry-3 branch. Telemetry-3 was squash-merged, so the PR branch was rebased onto main and force-pushed. The old head c7abf1b is no longer reachable from a branch. The new head 5c75e3f has an identical tree. Re-pin to the merge commit once #185 merges.
This comment has been minimized.
This comment has been minimized.
Conformance PR #185 merged to main as b380cbf. Its tree is identical to the branch head 5c75e3f that CI ran against. Pin to the merge commit so the revision stays reachable after the feature branch is deleted.
Contributor
Codex AI reviewNo actionable findings. The prior Rule 2 finding is addressed by the documented alternatives and rationale. Residual risk: tests were not executed, and the updated external workflow revision was not independently verified during this read-only review. Reviewed commit |
ParidelPooya
approved these changes
Nov 11, 2026
ParidelPooya
left a comment
Contributor
There was a problem hiding this comment.
Handler matches telemetry-4.yaml at b380cbf. LGTM.
Two small notes:
- The PR description says map iterations have no name without item_namer. Python names them map-item- (operation/map.py:97). The namer is still needed because the spec pins item-1 and item-2.
- lint-commits fails because three commit subjects are over 50 characters. This is fine if the PR is squash-merged.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds the
telemetry-4conformance handler. Onemap,process-items, runs over the event[1, 2]with max concurrency 1 and item nameritem-<item>. Each iteration runs one stepgreet-<item>that returns"Hello, <item>!". The telemetry plugin runs withfull-treeoperation detail andinput/outputon. The exported record must carry exactly fiveoperationsByNamekeys:process-items,item-1,item-2,greet-1,greet-2.The requirement is aws/aws-durable-execution-conformance-tests#185 (issue aws/aws-durable-execution-conformance-tests#184).
Why
top-leveldetail keeps onlyprocess-items.full-treedetail must recurse into each MapIteration context and keep the step under it, keyed by the user-supplied name. The deployed run shows the plugin recurses to depth 2, keeps the three CONTEXT summaries withoutmaxAttempt, and keeps the two STEP summaries withmaxAttempt1.Simpler options considered
Reuse an existing handler with
operation_detail="full-tree". telemetry-1 to telemetry-3 each run one top-level step. A step has no children. Sofull-treeon those handlers exports the same record astop-leveland tests no recursion. The requirement needs a context with children at depth 2, which only a map or parallel with inner steps produces.Hardcode
[1, 2]instead of reading the event. The runner sends the requirement'sInput. Reading the event keeps one source of truth, matches telemetry-1 to telemetry-3, and lets the YAMLInputdrive the handler.Drop
max_concurrency=1. With concurrent iterations the checkpoint order of the two iterations is not fixed. The requirement pins EventIds 2–12 in order. So iterations must run one at a time.Drop
item_namer. Without a namer the SDK checkpoints each MapIteration context with no name (JSmap-handler.ts:78setsname: undefined). The plugin keysoperationsByNameby name and drops unnamed operations. So the iteration contexts would be absent from the record and the requirement could not check them.Drop the
greetstep and return the item from the map function. Then the tree has depth 1 (map → iteration) and the depth-2 case the requirement exists for is untested.Changes
src/telemetry_4_full_tree_map.py: the handler. Same plugin configuration as telemetry-1 exceptoperation_detail="full-tree".src/Makefile:build-Telemetry4FullTreeMaptarget.template.yaml:Telemetry4FullTreeMap,TestDescription: [telemetry-4],FunctionName ${AWS::StackName}-telemetry-4.tests/test_telemetry_examples.py: runs the handler inDurableFunctionTestRunnerwith a fake logs client and asserts the five keys, their type/subType, andmaxAttemptonly on steps. Addstest_every_handler_module_is_deployed_by_exactly_one_functionso two functions cannot share a module.README.md: coverage row and layout line..github/workflows/telemetry-conformance-tests.yml: pinned to the conformance merge commitb380cbf(feat(telemetry): add telemetry-4 full-tree map record aws-durable-execution-conformance-tests#185).Verification
hatch run test:cov: 6665 passed, 6 skipped.hatch fmt --check: all checks passed.60cfa998, pinned toc7abf1b. Re-run at8f70085apinned tob380cbf: Run 42916007676 — 4 passed, 0 failed.