Repository navigation
fix: Factory wrappers bypass exclusive-group validation and allow both OTel views - #895
Conversation
|
@nandanadileep Thanks for working on this. I've updated issue #891 to narrow its scope to a test-code issue: the OTel test factory wrappers should preserve the built-in factories' registration metadata. A wrapper implementing only __durable_registration_api__ = 1
exclusive_group = "aws-durable-execution-otel-view"Please revise this PR to match that scope:
The updated issue includes the acceptance criteria and an existing inheritance-based test example. Please also update the PR title and description to reflect the test-only scope. |
OTel test factory wrappers omitted the built-in factories' registration marker and exclusive group, so competing views were not rejected at handler registration. - Restore production plugin and OTel classes to match main - Inherit or declare registration metadata on OTel wrappers - Reject competing wrapped views at durable_execution time Co-authored-by: Nandana Dileep <nandanadileep@users.noreply.github.com>
|
Thanks for updating this to match the test-only scope and preserving the OTel registration metadata in the wrappers. Appreciate the work on this! |
Fixes #891.
Focused Python fix for: [Bug]: Factory wrappers bypass exclusive-group validation and allow both OTel views
Changed implementation: packages/aws-durable-execution-sdk-python-otel/src/aws_durable_execution_sdk_python_otel/execution_plugin.py, packages/aws-durable-execution-sdk-python-otel/src/aws_durable_execution_sdk_python_otel/invocation_plugin.py, packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/plugin.py, packages/aws-durable-execution-sdk-python/src/aws_durable_execution_sdk_python/plugin_discovery.py.
Regression tests: packages/aws-durable-execution-sdk-python-otel/tests/e2e/test_view_registration.py.
Verification (working directory
.):.venv/bin/python -m pytest -q -x -p no:cacheprovider -- /workspace/packages/aws-durable-execution-sdk-python-otel/tests/e2e/test_view_registration.pyc7266bba8b711325bc92e7578f63c164774a3d4a.AI-assisted contribution: OpenCode using Autoloops wrote this patch. The automated harness independently ran the tests listed above. No human review is claimed.