Repository navigation
Conversation
|
The Failed job. I attempted to rerun it, but GitHub requires repository administrator access. Could a maintainer rerun the failed job? Could you also consider |
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
|
Automated review A maintainer will still review this — treat the notes below as a starting point. 📌 Commit This PR adds a suppressible synthesis-time warning to the The change is clean and backward-compatible. It warns rather than throws, so no previously-valid stack is rejected; the guard keys off the explicit prop and short-circuits on tokens ( 🔴 0 blocking · 🟡 0 recommended · ⚪ 0 optional Generated automatically. React 👍 or 👎 to tell us whether this review helped, so we can improve these reviews. |
|
The latest |
Issue # (if applicable)
Closes #32451.
Description of changes
An explicit empty availability-zone list silently creates no subnets and can produce misleading downstream errors. Add a suppressible synthesis warning without rejecting existing VPC configurations. Tokenized lists and normal AZ defaults remain accepted. The warning only applies to an explicitly empty availabilityZones list when subnets are requested; intentional subnetConfiguration: [] and maxAzs: 0 do not receive this warning.
Validation: 193 tests passed on this independent branch; changed TypeScript files passed ESLint. Strict JSII/TypeScript compilation passed with all five independent changes combined on a local validation branch.
Integration test exemption requested: this change only adds synth-time metadata. Unit tests cover empty, omitted, explicit nonempty, and tokenized AZ lists; no deployed resource behavior changes.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license