You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
EFS-backed deployments still need S3 connectivity. Explain the NAT and S3 gateway endpoint alternatives, the endpoint policy and subnet requirements, and memory/network considerations. Include an isolated-subnet example with an S3 gateway endpoint and an explicit memory allocation.
Validation
The README example compiled and translated with jsii-rosetta (1 snippet, no diagnostics).
Synthesized the example: no NAT gateways; S3 gateway endpoint route tables match the isolated deployment subnets; deployment Lambda has EFS mounted and 1024 MiB of memory.
Checked connectivity requirements against the official Lambda, S3 VPC endpoint, and CloudFormation custom-resource response documentation.
Documentation only; no resources are provisioned automatically by this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.
This documentation-only change rewrites the "EFS Support" section of the aws-s3-deployment README to explain the VPC networking and memory requirements for EFS-backed BucketDeployment. It corrects earlier wording to the actual useEfs: true prop and 512 MiB ephemeral storage, explains that the deployment function must reach both source and destination buckets over HTTPS (via a NAT gateway or an S3 gateway endpoint, since the construct creates no S3 endpoint itself), documents the CloudFormation custom-resource response-bucket timeout risk, and rewrites the example to demonstrate the no-NAT path. The prose claims are accurate against the construct code and AWS behavior, and the example's identifiers and API calls resolve correctly. No issues found on this change.
🔴 0 blocking · 🟡 0 recommended · ⚪ 0 optional
Generated automatically. React 👍 or 👎 to tell us whether this review helped, so we can improve these reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #19777.
Description
EFS-backed deployments still need S3 connectivity. Explain the NAT and S3 gateway endpoint alternatives, the endpoint policy and subnet requirements, and memory/network considerations. Include an isolated-subnet example with an S3 gateway endpoint and an explicit memory allocation.
Validation
Documentation only; no resources are provisioned automatically by this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.