You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The originally malformed FilterCriteria example was fixed in #23085, but this issue remains open for a general explanation of how to construct and combine filters.
Description of changes
Explain FilterCriteria.filter serialization, AND across fields, OR across values and filter entries, and source-specific data fields. Add a DynamoDB event pattern with event-name alternatives and a nested string-prefix comparison, together with its exact FilterCriteria JSON.
Describe any new or updated permissions being added
None. This is a documentation-only change.
Description of how you validated changes
Built aws-cdk-lib using the dependency versions pinned by the current main branch.
Compiled and translated the new README example with jsii-rosetta using the repository fixture.
Executed the exact README example against a DynamoDB stream and Lambda event source mapping. Compared its synthesized FilterCriteria to the JSON in the documentation and checked the parsed event pattern.
Ran jest aws-lambda/test/event-source-mapping.test.ts --runInBand --coverage=false (47 tests passed).
Reviewed the documentation against the implementation and checked git diff --check.
This PR adds a "Defining event filter criteria" subsection to the aws-lambda README (+50/-0), explaining how to compose event source mapping filter criteria: wrapping patterns in FilterCriteria.filter(), using FilterRule helpers, and the AND/OR combination semantics, with a worked DynamoDB example and its synthesized JSON. The documented serialization behavior, the FilterRule.or and FilterRule.beginsWith/prefix output, and the combination semantics all match the implementation and the linked AWS event-filtering guidance; the example resolves against the module's default fixture and demonstrates the feature. No issues found on this change.
🔴 0 blocking · 🟡 0 recommended · ⚪ 0 optional
Generated automatically. React 👍 or 👎 to tell us whether this review helped, so we can improve these reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #23214.
Reason for this change
The originally malformed FilterCriteria example was fixed in #23085, but this issue remains open for a general explanation of how to construct and combine filters.
Description of changes
Explain FilterCriteria.filter serialization, AND across fields, OR across values and filter entries, and source-specific data fields. Add a DynamoDB event pattern with event-name alternatives and a nested string-prefix comparison, together with its exact FilterCriteria JSON.
Describe any new or updated permissions being added
None. This is a documentation-only change.
Description of how you validated changes
aws-cdk-libusing the dependency versions pinned by the current main branch.jest aws-lambda/test/event-source-mapping.test.ts --runInBand --coverage=false(47 tests passed).git diff --check.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license