Skip to content

fix: file fingerprinting is now ~33% faster - #37802

Merged
mergify[bot] merged 5 commits into
mainfrom
huijbers/fingerprinting-speed
May 11, 2026
Merged

mergify[bot] merged 5 commits into
mainfrom
huijbers/fingerprinting-speed

Conversation

@rix0rrr

@rix0rrr rix0rrr commented May 8, 2026

Copy link
Copy Markdown
Contributor

During some recent investigations package fingerprinting was found to do a bunch of duplicate work (mostly statting the same files over and over again).

That and a number of minor tweaks bring the fingerprinting time of one specific directory down from ~19s to ~13s (about ~30% improvement), while maintaining byte-for-byte compatibility with the previous implementation.

In a future change, we will investigate changes that are allowed to change the hash to improve the performance even more.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr
rix0rrr requested a review from a team as a code owner May 8, 2026 13:15
@github-actions github-actions Bot added the p2 label May 8, 2026
@mergify mergify Bot added the contribution/core This is a PR that came from AWS. label May 8, 2026
@mergify
mergify Bot temporarily deployed to automation May 8, 2026 13:16 Inactive
@mergify
mergify Bot temporarily deployed to automation May 8, 2026 13:17 Inactive
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown
Contributor

⚠️ This pull request description does not follow the correct template structure.

PRs without a linked issue will receive lower priority for review and merging. Please update the description to follow the PR template and include a line like Closes #123 in the Issue section. If no existing issue matches your change, create one first.

@aws-cdk-automation aws-cdk-automation left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

During some recent investigations package fingerprinting was found to do
a bunch of duplicate work (mostly `stat`ting the same files over and
over again).

That and a number of minor tweaks bring the fingerprinting time of one
specific directory down from ~19s to ~13s (about ~30% improvement),
while maintaining byte-for-byte compatibility with the previous
implementation.

In a future change, we will investigate changes that are allowed
to change the hash to improve the performance even more.
@rix0rrr
rix0rrr force-pushed the huijbers/fingerprinting-speed branch from 62836ba to 783cb62 Compare May 8, 2026 13:36
@rix0rrr rix0rrr added the pr-linter/exempt-integ-test The PR linter will not require integ test changes label May 8, 2026
@aws-cdk-automation
aws-cdk-automation dismissed their stale review May 8, 2026 13:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@mergify

mergify Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify

mergify Bot commented May 11, 2026 •

Copy link
Copy Markdown
Contributor

Merge Queue Status

  • ✅ Entered queue — 2026-05-11 11:01 UTC · Rule: default-squash
  • ✅ Checks passed · in-place
  • ✅ Merged — 2026-05-11 11:57 UTC · at cd9f7dd2982f766f1c41d81f7f59ede5f7985a12 · squash

This pull request spent 56 minutes 7 seconds in the queue, including 30 minutes 31 seconds running CI.

Required conditions to merge

@mergify
mergify Bot temporarily deployed to automation May 11, 2026 11:26 Inactive
@mergify
mergify Bot temporarily deployed to automation May 11, 2026 11:26 Inactive
@mergify

mergify Bot commented May 11, 2026

Copy link
Copy Markdown
Contributor

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
mergify Bot merged commit b871018 into main May 11, 2026
19 of 20 checks passed
@mergify
mergify Bot deleted the huijbers/fingerprinting-speed branch May 11, 2026 11:57
@github-actions

Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 11, 2026

This branch was previously deployed

1 inactive deployment
automation — cd9f7dd2 Deployed May 11, 2026 by mergify[bot] via validate-pr #344908
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

contribution/core This is a PR that came from AWS. p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants