Repository navigation
fix(parser): accept ALB events with multi-value headers enabled - #8850
Open
Manishram-ai wants to merge 1 commit into
Open
Manishram-ai wants to merge 1 commit into
Manishram-ai wants to merge 1 commit into
Conversation
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number:
closes #8847
Summary
Changes
AlbModelnow hasmultiValueHeadersandmultiValueQueryStringParameters, andheadersandqueryStringParametersare no longer required. ALB sends one pair or the other depending on the target group's multi-value headers setting, and the pair it leaves out comes back as an empty dict, the same as in theALBEventdata class.event.headerskeeps working without a None check.albMultiValueQueryStringEvent.jsonandalbMultiValueHeadersEvent.json.User experience
Today every event from a target group with multi-value headers turned on fails with
Field requiredforheadersandqueryStringParameters, soAlbModelcan't be used with that setting at all. With this change those events parse, and the snippet in the issue prints{'parameter1': ['value1', 'value2'], 'parameter2': ['value']}. Events from target groups without multi-value headers parse the same as before, with the two new fields set to{}.Verification
developwithField requiredforheadersandqueryStringParameters, and pass with this change.tests/unit/parserandtests/functional/parser: 274 passed on Python 3.10, 3.12 and 3.14.ruff check,ruff format --checkandmypyare clean, andtests/performancepasses.tests/events.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.