Repository navigation
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Issue number: closes #8830
Summary
Changes
LoggerBufferCacheandKeyBufferCachesized items withlen(str(item)), which counts characters. They now use one small helper,_item_size(), that returnslen(str(item).encode("utf-8")). It is used in all three places (the "bigger than the whole buffer" check,add, andremove_oldest), so the running size stays consistent when items are evicted.No docs change:
docs/core/logger.mdalready saysmax_bytesis the "maximum size of the log buffer in bytes".User experience
Before: with
max_bytes=1600,logger.debug("é" * 1000)was buffered with no warning, though the record is about 2.2 KB in UTF-8.After: the record is counted in bytes, so it is treated like any record bigger than the buffer:
PowertoolsUserWarning("Cannot add item to the buffer...")and the log is written right away. ASCII-only logs behave the same as before.Verification
I used an AI assistant (Claude) to help write this change. I ran the tests below myself.
New tests:
tests/unit/logger/required_dependencies/test_logger_buffer_cache.py:test_cache_size_counts_utf8_bytes,test_item_larger_than_cache_in_bytestests/functional/logger/required_dependencies/test_powertools_logger_buffer.py:test_log_record_exceeding_buffer_size_in_bytes(publicLoggerAPI only)On
develop(fix reverted, tests kept):With the fix:
Full
uv run pytest -q tests/unit tests/functionalon this branch: 4056 passed, 73 skipped, 3 failed. The same 3 fail ondevelopwithout my change, and they come from test order, not this PR: oncetests/functional/metrics/datadogis collected,ddtraceis imported and addsdd.*keys to log records, sotest_append_context_keys_handles_empty_dictandtest_log_dict_key_strip_nonessee extra keys (both pass whentests/functional/loggerruns alone). The third,test_datadog_write_to_log_with_env_variable, passes when run alone. On my machine some full runs also hung in the Redis idempotency tests ondeveloptoo, so I ran the logger tests separately as well.ruff format --checkandruff checkon the changed files: clean.mypy aws_lambda_powertools/logging/: "Success: no issues found in 17 source files".By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.