Repository navigation
docs(idempotency): fix local_cache_max_items default in IdempotencyConfig docstring - #8731
Conversation
|
Thanks a lot for your first contribution! Please check out our contributing guidelines and don't hesitate to ask whatever you need. |
dedab2d to
9140cab
Compare
…nfig docstring The docstring said the default was 1024; the signature and the docs table use 256.
9140cab to
a6d96c5
Compare
|
Thanks for the PR and for filling in the verification section, that helps. Heads up that the review may take a few days: this goes into 3.41.0 and I review every PR against a real service before approving, one at a time. No need to rebase or ping in the meantime, I'll come back here. |
leandrodamascena
left a comment
There was a problem hiding this comment.
Thanks @lechakrawarthy. Checked the signature and the docs table, both say 256, so the docstring was the odd one out. Approved. This goes out in 3.41.0, no rebase needed, credit in the release notes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #8731 +/- ##
========================================
Coverage 97.17% 97.17%
========================================
Files 323 323
Lines 16606 16606
Branches 1504 1504
========================================
Hits 16137 16137
Misses 328 328
Partials 141 141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|



Issue number:
closes #8729
Summary
Changes
The
IdempotencyConfigdocstring saidlocal_cache_max_itemsdefaults to 1024. The signature (local_cache_max_items: int = 256) and the docs table both use 256, so the docstring now says 256. Docstring-only change, no behaviour change.Verification
Ran locally on Windows, Python from
uv sync --locked --extra all --extra redis --extra datamasking(skipped thevalkeyextra becausevalkey-glidedoes not build on Windows):AI disclosure
This modification was implemented with the assistance of an AI-powered coding assistant. I executed the commands provided, and the resulting output is reproduced below exactly as displayed.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.