Understanding of the compress option #1890

Activity

1. rubenfonseca

   added

   documentationImprovements or additions to documentationImprovements or additions to documentation

   event_handlers

   triagePending triage from maintainersPending triage from maintainers

   on Feb 2, 2023
2. rubenfonseca

   self-assigned this

   on Feb 3, 2023
3. heitorlessa

   added

   help wantedCould use a second pair of eyes/handsCould use a second pair of eyes/hands

   and removed

   triagePending triage from maintainersPending triage from maintainers

   on Mar 10, 2023
4. leandrodamascena

   assigned

   leandrodamascena

   and unassigned

   rubenfonseca

   on Apr 14, 2023
5. leandrodamascena

   assigned

   heitorlessa

   and unassigned

   leandrodamascena

   on Jun 8, 2023
6. heitorlessa commented on Jun 8, 2023

   

   heitorlessa

   on Jun 8, 2023

   Contributor

   More actions

   creating a PR for this now...

   hey @nilsm0hr, I've read between the lines that you didn't pass a str or bytes to the Response(body=...). Then after investigating the code, or type hints in your IDE within Response, you've noticed we take string or bytes, then use Gzip to compress it hence changing to a string.

   I suspect you went from:

   @app.get("/todos", compress=True)
   def get_todos():
       return Response(200, content_types.APPLICATION_JSON, {"hello": "blah"})

   To:

   @app.get("/todos", compress=True)
   def get_todos():
       return Response(200, content_types.APPLICATION_JSON, json.dumps({"hello": "blah"}))
7. heitorlessa commented on Jun 8, 2023

   

   heitorlessa

   on Jun 8, 2023

   Contributor

   More actions

   Expanded the compress section example with an additional route using Response as the return. PR incoming

   
8. heitorlessa

   linked a pull request that will close this issuedocs(event_handler): improve compress example using Response class #2426on Jun 8, 2023
9. heitorlessa

   closed this as completedin #2426on Jun 9, 2023
10. github-actions commented on Jun 9, 2023

    

    github-actionsBot

    on Jun 9, 2023

    Contributor

    More actions

    ⚠️COMMENT VISIBILITY WARNING⚠️

    This issue is now closed. Please be mindful that future comments are hard for our team to see.

    If you need more assistance, please either tag a team member or open a new issue that references this one.

    If you wish to keep having a conversation with other community members under this issue feel free to do so.
11. github-actions

    added

    pending-releaseFix or implementation already in dev waiting to be releasedFix or implementation already in dev waiting to be released

    on Jun 9, 2023
12. github-actions commented on Jun 16, 2023

    

    github-actionsBot

    on Jun 16, 2023

    Contributor

    More actions

    This is now released under 2.17.0 version!
13. github-actions

    removed

    pending-releaseFix or implementation already in dev waiting to be releasedFix or implementation already in dev waiting to be released

    on Jun 16, 2023