Skip to content

[ec2-controller] LaunchTemplate: adoption fails #3169

Open

Description

@gobos12

Describe the bug

Adoption fails: the read never sets spec.name. Found by launch-template-adoption, at wait-synced.

Observed:

LaunchTemplate.ec2.services.k8s.aws "..." is invalid: spec.name: Required value

then Terminal: field DefaultVersion is required.

Cause: sdkFind never sets spec.name from LaunchTemplateName, so the adopted spec can't be written back. The first reconcile has already added the finalizer, so the next one skips adoption and updates from the empty spec, which hits the DefaultVersion check.

Related: #2932, LaunchTemplate adoption failing with adopt-or-create. Open aws-controllers-k8s/ec2-controller#347 keys LaunchTemplate by name, which changes how it's adopted.

Steps to reproduce

Adopt a launch template by ID, with adoption-policy: adopt and no spec.

Expected outcome

The adopted spec includes name, and the CR syncs.

Environment

  • Kubernetes version: 1.35
  • Using EKS (yes/no), if so version? Yes, 1.35
  • AWS service targeted (S3, RDS, etc.): EC2
  • ec2-controller v1.24.0, ACK runtime v0.68.0, us-west-2

Activity

  1. added
    kind/bugCategorizes issue or PR as related to a bug.
    service/ec2Indicates issues or PRs that are related to ec2-controller.
    on Nov 12, 2026
  2. github-actions commented on Nov 12, 2026

    @github-actions

    Hello @gobos12 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

    We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

    You can find more information about ACK on our website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/adoption-annotationIssues or PRs related to ACK Adoption by Annotation featurekind/bugCategorizes issue or PR as related to a bug.service/ec2Indicates issues or PRs that are related to ec2-controller.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions