Skip to content

ACK EC2 Controller doesn't adopt VPC Peering Connection #2480

Closed

Description

Describe the bug
Same as here : #2419
Steps to reproduce

apiVersion: ec2.services.k8s.aws/v1alpha1
kind: VPCPeeringConnection
metadata:
  annotations:
    services.k8s.aws/adopted: "true"
    services.k8s.aws/adoption-fields: |
      {
        "vpcPeeringConnectionID": "pcx-03240039307ec4900"
      }
    services.k8s.aws/adoption-policy: adopt
  name: test-vpc-peer-to-test
  namespace: ci-clusters
status:
  conditions:
  - lastTransitionTime: "2025-05-14T08:27:04Z"
    message: Reference resolution failed
    reason: 'resource reference wrapper or ID required: VPCID,VPCRef'
    status: Unknown
    type: ACK.ReferencesResolved

Image

Expected outcome
A concise description of what you expected to happen.

Environment

  • Kubernetes version 1.30
  • Using EKS (yes/no), if so version? 1.30
  • AWS service targeted (S3, RDS, etc.) ACK EC2 1.4.4

Activity

  1. github-actions commented on May 14, 2025

    @github-actions

    Hello @stefanescualexandrumihai 👋 Thank you for opening an issue in ACK! A maintainer will triage this issue soon.

    We encourage community contributions, so if you're interested in tackling this yourself or suggesting a solution, please check out our Contribution and Code of Conduct guidelines.

    You can find more information about ACK on our website.

  2. michaelhtm commented on May 14, 2025

    @michaelhtm
    Member

    Hi @stefanescualexandrumihai
    Seems like the configuration is not correct. The services.k8s.aws/adopted: true is added by the controller when it successfully adopts the resource.
    I just tested it successfully wit the following configuration:

    apiVersion: ec2.services.k8s.aws/v1alpha1
    kind: VPCPeeringConnection
    metadata:
      name: my-pcs
      annotations:
        services.k8s.aws/adoption-policy: adopt
        services.k8s.aws/adoption-fields: |
          {
            "vpcPeeringConnectionID": "pcx-01b143ceb64da5dd5"
          }
  3. added
    service/ec2Indicates issues or PRs that are related to ec2-controller.
    area/adoption-annotationIssues or PRs related to ACK Adoption by Annotation feature
    on May 14, 2025
  4. stefanescualexandrumihai commented on May 14, 2025

    @stefanescualexandrumihai
    Author

    Hi! Sorry for that, copy-pasta issue. The ACK EC2 Controller is working as expected. I'll close the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    area/adoption-annotationIssues or PRs related to ACK Adoption by Annotation featureservice/ec2Indicates issues or PRs that are related to ec2-controller.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions