Repository navigation
fix(E3635): add Neptune x2iezn and x2iedn instance classes missing from pricing data - #4973
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
…om pricing data Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Signed-off-by: Alex Castillo <alex.castillog33@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4886
Issue #, if available: #4886
Description of changes:
E3635 flags valid Neptune instance classes because
dbinstanceclass_enum.jsonis generated from the Pricing API, which does not list them. The issue reportsdb.x2iezn.*in us-east-1 and us-west-2 anddb.x2iedn.*in ap-southeast-1 as returned byaws rds describe-orderable-db-instance-options --engine neptune; the Neptune instance types page listsx2ieznin sizes 2xlarge to 12xlarge andx2iednin sizes xlarge to 32xlarge.scripts/update_specs_from_pricing.pymerges a small_NEPTUNE_EXTRA_INSTANCE_TYPESmap into the Neptune results, so the next scheduled regeneration keeps these classes (same approach asdb.serverlessfor DocumentDB in fix(E3620): Add db.serverless to the DocumentDB instance classes #4761).dbinstanceclass_enum.jsongets the same entries: only the regions and sizes from the issue (x2iednwas already present in other regions).test/unit/rules/resources/neptune/test_db_instance_class_enum.pycovers the reported classes plus a negative case. Four of the seven cases fail without the data change and all pass with it.This PR was prepared with the assistance of an AI coding agent (Claude Code).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.