Repository navigation
V1 - Reduce usage of awsType - #3257
Merged
kddejong merged 3 commits intoMay 21, 2024
Merged
Conversation
kddejong
force-pushed
the
v1-cleanup/2024/05/17-2
branch
3 times, most recently
from
May 21, 2024 15:57
c49a8e9 to
9697f13
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3257 +/- ##
==========================================
- Coverage 92.67% 92.53% -0.15%
==========================================
Files 308 307 -1
Lines 10639 10591 -48
Branches 2263 2244 -19
==========================================
- Hits 9860 9800 -60
- Misses 446 454 +8
- Partials 333 337 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
kddejong
force-pushed
the
v1-cleanup/2024/05/17-2
branch
from
May 21, 2024 16:40
9697f13 to
60bc2ce
Compare
kddejong
force-pushed
the
v1-cleanup/2024/05/17-2
branch
from
May 21, 2024 17:36
60bc2ce to
72e28ba
Compare
github-merge-queue Bot
pushed a commit
to cdklabs/awscdk-service-spec
that referenced
this pull request
Sep 30, 2024
Our [feat(sources): update stateful-resources](#1106) PR is currently failing to build: ```console 👾 build » compile » build:db | ts-node build/build-db.ts FAIL SyntaxError: Unexpected non-whitespace character after JSON at position 3 ``` This happens because the `StatefulResources.json` file got updated with an invalid value. Our workflow updates this with the contents of `StatefulResources.json` coming from [cfn-lint](https://github.com/aws-cloudformation/cfn-lint). However, In aws-cloudformation/cfn-lint#3257, this file was [removed](https://raw.githubusercontent.com/aws-cloudformation/cfn-lint/main/src/cfnlint/data/AdditionalSpecs/StatefulResources.json) (it is now inlined inside the python file that was using it). This results in the file being updated with the string `404: Not Found` - which is not a valid JSON. In this scenario, we shouldn't have even created the PR, but rather fail during the workflow execution. We didn't because our workflow ignores http status codes when downloading a source, this PR fixes that. ### Notes - This replaces build failure with workflow execution failure, but we still need to figure out how to handle the file removal.
This was referenced Oct 24, 2026
E7010/I7010: more than 200
Mappings not reported; only the keys inside one mapping are counted
#4878
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.