Skip to content

V1 - Reduce usage of awsType - #3257

Merged
kddejong merged 3 commits into
aws-cloudformation:mainfrom
kddejong:v1-cleanup/2024/05/17-2
May 21, 2024
Merged

kddejong merged 3 commits into
aws-cloudformation:mainfrom
kddejong:v1-cleanup/2024/05/17-2

Conversation

@kddejong

Copy link
Copy Markdown
Contributor

Issue #, if available:

Description of changes:

  • Reduce usage of awsType

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@kddejong
kddejong force-pushed the v1-cleanup/2024/05/17-2 branch 3 times, most recently from c49a8e9 to 9697f13 Compare May 21, 2024 15:57
@codecov

codecov Bot commented May 21, 2024 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 99.04306% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 92.53%. Comparing base (5b06881) to head (60bc2ce).

❗ Current head 60bc2ce differs from pull request most recent head 72e28ba

Please upload reports for the commit 72e28ba to get more accurate results.

Files Patch % Lines
src/cfnlint/rules/_Rules.py 66.66% 0 Missing and 1 partial ⚠️
src/cfnlint/rules/conditions/Equals.py 66.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3257      +/-   ##
==========================================
- Coverage   92.67%   92.53%   -0.15%     
==========================================
  Files         308      307       -1     
  Lines       10639    10591      -48     
  Branches     2263     2244      -19     
==========================================
- Hits         9860     9800      -60     
- Misses        446      454       +8     
- Partials      333      337       +4     
Flag Coverage Δ
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kddejong
kddejong force-pushed the v1-cleanup/2024/05/17-2 branch from 9697f13 to 60bc2ce Compare May 21, 2024 16:40
@kddejong
kddejong force-pushed the v1-cleanup/2024/05/17-2 branch from 60bc2ce to 72e28ba Compare May 21, 2024 17:36
@kddejong
kddejong merged commit 27f45ff into aws-cloudformation:main May 21, 2024
@kddejong
kddejong deleted the v1-cleanup/2024/05/17-2 branch May 21, 2024 17:42
github-merge-queue Bot pushed a commit to cdklabs/awscdk-service-spec that referenced this pull request Sep 30, 2024
Our [feat(sources): update
stateful-resources](#1106)
PR is currently failing to build:

```console
👾 build » compile » build:db | ts-node build/build-db.ts
FAIL


SyntaxError: Unexpected non-whitespace character after JSON at position 3
```

This happens because the `StatefulResources.json` file got updated with
an invalid value. Our workflow updates this with the contents of
`StatefulResources.json` coming from
[cfn-lint](https://github.com/aws-cloudformation/cfn-lint). However, In
aws-cloudformation/cfn-lint#3257, this file was
[removed](https://raw.githubusercontent.com/aws-cloudformation/cfn-lint/main/src/cfnlint/data/AdditionalSpecs/StatefulResources.json)
(it is now inlined inside the python file that was using it). This
results in the file being updated with the string `404: Not Found` -
which is not a valid JSON.

In this scenario, we shouldn't have even created the PR, but rather fail
during the workflow execution. We didn't because our workflow ignores
http status codes when downloading a source, this PR fixes that.

### Notes

- This replaces build failure with workflow execution failure, but we
still need to figure out how to handle the file removal.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant