cmake: fix "retde-decompiler" typo in RETDEC_ENABLE component matching#1237
Open
takano32 wants to merge 1 commit into
Open
cmake: fix "retde-decompiler" typo in RETDEC_ENABLE component matching#1237takano32 wants to merge 1 commit into
takano32 wants to merge 1 commit into
Conversation
The match string for the retdec-decompiler component was missing a
'c', so the documented invocation
cmake -DRETDEC_ENABLE=retdec-decompiler ..
never matched any component. Since no component flag got set,
RETDEC_ENABLE_ALL stayed ON and the entire project was built instead
of the requested minimal set; in a mixed list such as
-DRETDEC_ENABLE=retdec-decompiler,fileformat the decompiler component
was silently dropped.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014nNMVbAuffaPPQuYdLZgD1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
cmake/options.cmakematches the tokens of the documented-DRETDEC_ENABLE=<comma-separated component list>interface (README, "Build and Installation") against component names, but the entry for the decompiler was missing a character:Because the token
retdec-decompilernever matches the misspelled string, the documented invocationsets no component flag at all, so
RETDEC_ENABLE_ALLstaysONand the entire project is built instead of the requested minimal set. In a mixed list such as-DRETDEC_ENABLE=retdec-decompiler,fileformat, the decompiler component is silently dropped.Fix
One character:
"retde-decompiler"→"retdec-decompiler"(the component name used bysrc/CMakeLists.txt). The misspelled string appears nowhere else in the repository.Testing
Configuring a minimal project that includes
options.cmakewith-DRETDEC_ENABLE=retdec-decompiler:RETDEC_ENABLE_RETDEC_DECOMPILERRETDEC_ENABLE_ALLALL)🤖 Generated with Claude Code
https://claude.ai/code/session_014nNMVbAuffaPPQuYdLZgD1