test: prevent duplicate metrics collector registration attempted#2957
Merged
miparnisari merged 1 commit intomainfrom Mar 6, 2026
Merged
test: prevent duplicate metrics collector registration attempted#2957miparnisari merged 1 commit intomainfrom
miparnisari merged 1 commit intomainfrom
Conversation
github-actions
bot
added
area/cli
tstirrat15
approved these changes
Mar 6, 2026
Contributor
tstirrat15
left a comment
tstirrat15
left a comment
There was a problem hiding this comment.
Yeah, this makes sense to me.
miparnisari
force-pushed
the
test-flaky-dup-metrics
branch
from
678b439 to
779bb08
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. ❌ Your project status has failed because the head coverage (74.46%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2957 +/- ##
===========================================
+ Coverage 48.71% 74.46% +25.75%
===========================================
Files 427 494 +67
Lines 54556 60626 +6070
===========================================
+ Hits 26571 45138 +18567
+ Misses 25263 12318 -12945
- Partials 2722 3170 +448 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a test flake.
The other way to prevent this flake is to do what #2829 says, but this is more work and riskier.