feat: implement a proper BFS when doing IterSubjects/IterResources for recursive nodes#2838
Merged
feat: implement a proper BFS when doing IterSubjects/IterResources for recursive nodes#2838
Conversation
github-actions
bot
added
the
area/tooling
barakmich
force-pushed
the
barakmich/better_recursion
branch
from
d73b323 to
3264c51
Compare
Codecov Report❌ Patch coverage is
❌ Your project check has failed because the head coverage (74.30%) is below the target coverage (75.00%). You can increase the head coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2838 +/- ##
==========================================
- Coverage 74.35% 74.30% -0.04%
==========================================
Files 483 483
Lines 56954 57084 +130
==========================================
+ Hits 42341 42411 +70
- Misses 11644 11686 +42
- Partials 2969 2987 +18 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tstirrat15
approved these changes
Jan 21, 2026
| iter := NewFixedIterator(paths...) | ||
| recursive := NewRecursiveIterator(iter, "folder", "parent") | ||
|
|
||
| ds, err := memdb.NewMemdbDatastore(0, 0, memdb.DisableGC) |
Contributor
There was a problem hiding this comment.
I was wondering about this in other tests too - if we're using fixed iterators, do we need the datastore at all? When I removed it from some of the tests it seemed to work just fine.
Contributor
Author
There was a problem hiding this comment.
I'll file a ticket to check and simplify
tstirrat15
force-pushed
the
barakmich/better_recursion
branch
from
3264c51 to
6d84587
Compare
barakmich
force-pushed
the
barakmich/better_recursion
branch
from
6d84587 to
7fa8efb
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
References