Skip to content

feat: finish initial implementation of IterSubjects#2809

Merged
barakmich merged 5 commits intomainfrom
barakmich/iter_subjects
Jan 13, 2026
Merged

feat: finish initial implementation of IterSubjects#2809
barakmich merged 5 commits intomainfrom
barakmich/iter_subjects

Conversation

@barakmich
Copy link
Copy Markdown
Contributor

Description

Testing

References

@barakmich barakmich requested a review from a team as a code owner January 12, 2026 23:01
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Jan 12, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 72.50996% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.43%. Comparing base (9171c3f) to head (38eb832).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/query/arrow.go 61.71% 13 Missing and 5 partials ⚠️
pkg/query/union.go 55.56% 10 Missing and 6 partials ⚠️
pkg/query/exclusion.go 82.86% 6 Missing and 6 partials ⚠️
pkg/query/intersection.go 76.00% 6 Missing and 6 partials ⚠️
pkg/query/intersection_arrow.go 78.73% 5 Missing and 5 partials ⚠️
pkg/query/datastore.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
- Coverage   78.52%   78.43%   -0.09%     
==========================================
  Files         459      459              
  Lines       44448    44662     +214     
==========================================
+ Hits        34898    35025     +127     
- Misses       6723     6777      +54     
- Partials     2827     2860      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

tstirrat15
tstirrat15 previously approved these changes Jan 13, 2026
Copy link
Copy Markdown
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. see comments

Comment thread pkg/query/arrow.go
Comment thread pkg/query/exclusion.go Outdated
Comment thread pkg/query/intersection_test.go
Comment thread pkg/query/union_test.go
Copy link
Copy Markdown
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@barakmich barakmich added this pull request to the merge queue Jan 13, 2026
Merged via the queue into main with commit dddce02 Jan 13, 2026
44 of 45 checks passed
@barakmich barakmich deleted the barakmich/iter_subjects branch January 13, 2026 23:07
@github-actions github-actions bot locked and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants