fix(mysql,crdb): touch without expiration should remove the expiration#2796
Merged
miparnisari merged 1 commit intomainfrom Dec 31, 2025
Merged
fix(mysql,crdb): touch without expiration should remove the expiration#2796miparnisari merged 1 commit intomainfrom
miparnisari merged 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2796 +/- ##
==========================================
- Coverage 77.71% 77.66% -0.05%
==========================================
Files 472 472
Lines 49709 49716 +7
==========================================
- Hits 38627 38606 -21
- Misses 8231 8249 +18
- Partials 2851 2861 +10 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
miparnisari
force-pushed
the
test-rel-expiration
branch
from
2346710 to
0b1bb6e
Compare
miparnisari
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the MySQL and CRDB datastores, a touch without an expiration will leave the existing expiration intact if the relationship already has one. This is a bug.