test: use synctest in some CRDB pool retry tests#2754
Merged
miparnisari merged 2 commits intoauthzed:mainfrom Feb 13, 2026
Merged
test: use synctest in some CRDB pool retry tests#2754miparnisari merged 2 commits intoauthzed:mainfrom
miparnisari merged 2 commits intoauthzed:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2754 +/- ##
===========================================
+ Coverage 50.01% 74.58% +24.57%
===========================================
Files 417 484 +67
Lines 52438 58531 +6093
===========================================
+ Hits 26224 43651 +17427
+ Misses 23562 11810 -11752
- Partials 2652 3070 +418 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
1712d3c to
483cf87
Compare
483cf87 to
e65d882
Compare
miparnisari
reviewed
Feb 12, 2026
miparnisari
approved these changes
Feb 13, 2026
9bb0d42 to
22d64e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the CRDB pool retry tests to use Go's
testing/synctestpackage for better time simulation and test reliability.Fixes #2713
Changes
synctest.Test(t, func(t *testing.T) { ... })t.Context()instead ofcontext.Background()t.Parallel()for concurrent test executionBenefits