Skip to content

fix: set missing fields in postgresRevision.MarshalBinary#2708

Merged
ostafen merged 1 commit intomainfrom
fix/postgres-revision-marshal
Nov 17, 2025
Merged

fix: set missing fields in postgresRevision.MarshalBinary#2708
ostafen merged 1 commit intomainfrom
fix/postgres-revision-marshal

Conversation

@ostafen
Copy link
Copy Markdown
Contributor

@ostafen ostafen commented Nov 17, 2025

Description

This change sets OptionalTxid and OptionalTimestamp when marshalling a postgres revision to probuf.

Testing

Add test case to TestRevisionSerDe.

@ostafen ostafen requested a review from a team as a code owner November 17, 2025 06:42
@github-actions github-actions bot added area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) labels Nov 17, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 17, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.02%. Comparing base (82ab4d3) to head (ef171d7).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2708      +/-   ##
==========================================
- Coverage   77.10%   77.02%   -0.07%     
==========================================
  Files         462      462              
  Lines       49007    49009       +2     
==========================================
- Hits        37781    37746      -35     
- Misses       8458     8485      +27     
- Partials     2768     2778      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ostafen ostafen marked this pull request as draft November 17, 2025 06:47
@ostafen ostafen force-pushed the fix/postgres-revision-marshal branch from c41e117 to ef171d7 Compare November 17, 2025 07:22
@ostafen ostafen marked this pull request as ready for review November 17, 2025 13:23
@ostafen ostafen requested a review from vroldanbet November 17, 2025 13:23
@ostafen ostafen added this pull request to the merge queue Nov 17, 2025
Merged via the queue into main with commit 44f2acf Nov 17, 2025
77 of 78 checks passed
@ostafen ostafen deleted the fix/postgres-revision-marshal branch November 17, 2025 16:08
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/datastore Affects the storage system area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants