Skip to content

fix: span handling in LR3#2574

Merged
josephschorr merged 1 commit intoauthzed:mainfrom
josephschorr:lr3-span-handling
Sep 19, 2025
Merged

fix: span handling in LR3#2574
josephschorr merged 1 commit intoauthzed:mainfrom
josephschorr:lr3-span-handling

Conversation

@josephschorr
Copy link
Copy Markdown
Member

Iterators cannot use spans using the traditional defer span.End() as it will be called when the chained iterator is returned. Instead, we add a new cter function for wrapping other iterators

Iterators cannot use spans using the traditional `defer span.End()` as it will be called when the chained iterator is returned. Instead, we add a new cter function for wrapping other iterators
@josephschorr josephschorr requested a review from a team as a code owner September 19, 2025 21:40
@github-actions github-actions bot added the area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools) label Sep 19, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.60%. Comparing base (798ae49) to head (fc97d8c).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2574      +/-   ##
==========================================
- Coverage   77.62%   77.60%   -0.02%     
==========================================
  Files         440      440              
  Lines       54067    54097      +30     
==========================================
+ Hits        41966    41975       +9     
- Misses       9481     9496      +15     
- Partials     2620     2626       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@tstirrat15 tstirrat15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes make sense to me. It does make me wonder how we'll instrument the new query library.

@josephschorr josephschorr added this pull request to the merge queue Sep 19, 2025
Merged via the queue into authzed:main with commit 3098088 Sep 19, 2025
46 checks passed
@josephschorr josephschorr deleted the lr3-span-handling branch September 19, 2025 22:20
@github-actions github-actions bot locked and limited conversation to collaborators Sep 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area/tooling Affects the dev or user toolchain (e.g. tests, ci, build tools)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants