Merged
Conversation
Iterators cannot use spans using the traditional `defer span.End()` as it will be called when the chained iterator is returned. Instead, we add a new cter function for wrapping other iterators
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2574 +/- ##
==========================================
- Coverage 77.62% 77.60% -0.02%
==========================================
Files 440 440
Lines 54067 54097 +30
==========================================
+ Hits 41966 41975 +9
- Misses 9481 9496 +15
- Partials 2620 2626 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
tstirrat15
approved these changes
Sep 19, 2025
Contributor
tstirrat15
left a comment
There was a problem hiding this comment.
Changes make sense to me. It does make me wonder how we'll instrument the new query library.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Iterators cannot use spans using the traditional
defer span.End()as it will be called when the chained iterator is returned. Instead, we add a new cter function for wrapping other iterators