Merged
Conversation
github-actions
bot
added
area/cli
vroldanbet
force-pushed
the
remove-deprecated-otel-middleware
branch
from
37f77ac to
ab2c854
Compare
This commit removes the usage of deprecated otel go SDK gRPC interceptors. Those were superfluous since we were already making use of the new StatsHandler installed in the gRPC server. I verified that traces are being correctly collected via otel, and that the TraceID shows up in the logs. Also tested the grpc Gateway, but did not verify the Dispatch API. I also identified this was missing in the testserver, so I added it, along with missing request logs.
vroldanbet
force-pushed
the
remove-deprecated-otel-middleware
branch
from
ab2c854 to
5684c22
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2561 +/- ##
==========================================
- Coverage 77.70% 77.69% -0.00%
==========================================
Files 439 439
Lines 53526 53519 -7
==========================================
- Hits 41586 41578 -8
- Misses 9351 9352 +1
Partials 2589 2589 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This commit removes the use of deprecated OTEL Go SDK gRPC interceptors. Those were superfluous since we were already making use of the new StatsHandler installed in the gRPC server.
I also identified that OTel tracing was missing in the test server, so I added it.
I also noticed logs were not showing up because we had not correctly wired up the logger used by the middleware.
Testing
I verified that traces are being correctly collected via otel using Jaeger, and that the TraceID shows up in the logs. Also tested the grpc Gateway, but did not verify the Dispatch API.
References
Follow up to #2556