Skip to content

feat: add withAuthenticationRequired#1060

Merged
pamapa merged 1 commit into
mainfrom
with-authentication-required
Dec 18, 2023
Merged

feat: add withAuthenticationRequired#1060
pamapa merged 1 commit into
mainfrom
with-authentication-required

Conversation

@pamapa

@pamapa pamapa commented Dec 15, 2023

Copy link
Copy Markdown
Member

Closes/fixes #issue

Checklist

  • This PR makes changes to the public API
  • I have included links for closing relevant issue numbers

Heavy inspired by auth0 code found here https://github.com/auth0/auth0-react/blob/main/src/with-authentication-required.tsx

@pamapa pamapa added the enhancement New feature or request label Dec 15, 2023
@codecov

codecov Bot commented Dec 15, 2023

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (540d1c7) 81.45% compared to head (23888aa) 83.80%.
Report is 1 commits behind head on main.

❗ Current head 23888aa differs from pull request most recent head 0a81bcc. Consider uploading reports for the commit 0a81bcc to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
+ Coverage   81.45%   83.80%   +2.35%     
==========================================
  Files           9       10       +1     
  Lines         124      142      +18     
  Branches       20       25       +5     
==========================================
+ Hits          101      119      +18     
  Misses         16       16              
  Partials        7        7              
Flag Coverage Δ
unittests 83.80% <100.00%> (+2.35%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pamapa pamapa marked this pull request as draft December 15, 2023 11:14
@pamapa pamapa force-pushed the with-authentication-required branch 2 times, most recently from e280c47 to 23888aa Compare December 15, 2023 13:02
@pamapa pamapa marked this pull request as ready for review December 15, 2023 13:06
@pamapa pamapa force-pushed the with-authentication-required branch from 23888aa to 0a81bcc Compare December 15, 2023 13:14
@pamapa pamapa merged commit de3404b into main Dec 18, 2023
@pamapa pamapa deleted the with-authentication-required branch December 18, 2023 12:32
@fractal-joe

Copy link
Copy Markdown

@pamapa Which version is this available in?

@pamapa pamapa added this to the 3.0.0-rc.0 milestone Dec 22, 2023
@pamapa

pamapa commented Dec 22, 2023

Copy link
Copy Markdown
Member Author

Will be part of 3.0.0-rc.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants