Repository navigation
fix: restore Bash session startup with shell integration - #390
Merged
Merged
Conversation
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bash sessions exited immediately because shell integration appended
--rcfileafter the default-loption. This left startup stuck on the first-session placeholder and new tabs repeatedly reconnecting withno such session.Move Bash's
--rcfile <path>before the existing arguments while retaining login mode, caller arguments, and the other shell plans' ordering. Add a regression test that starts a real Bash process with login mode and integration options.Validation: real Bash regression test, desktop Go tests,
go vet -tags webkit2_41 ./..., and desktop frontend type-check/build.