Skip to content
This repository was archived by the owner on Dec 15, 2022. It is now read-only.

Fixes #87: Do not cache search results if regular expression contains \G#88

Merged
maxbrunsfeld merged 1 commit into
atom:masterfrom
alexdima:no-cache-for-G
Sep 19, 2018
Merged

Fixes #87: Do not cache search results if regular expression contains \G#88
maxbrunsfeld merged 1 commit into
atom:masterfrom
alexdima:no-cache-for-G

Conversation

@alexdima
Copy link
Copy Markdown
Contributor

@alexdima alexdima commented Sep 19, 2018

See #87

  • Disables caching if the regular expression contains \G.
  • Adds a regression test.

(fyi @daviwil @maxbrunsfeld)

Copy link
Copy Markdown
Contributor

@maxbrunsfeld maxbrunsfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for tracking this down @alexandrudima. I just left one suggestion.

Comment thread src/onig-reg-exp.cc
@maxbrunsfeld maxbrunsfeld merged commit bfb1753 into atom:master Sep 19, 2018
@maxbrunsfeld
Copy link
Copy Markdown
Contributor

This change is in v7.0.2.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants