This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Revert argumetns matching#260
Merged
winstliu merged 1 commit intoatom:masterfrom Nov 19, 2015
MaximSokolov:revert-arguments-matching
Merged
Revert argumetns matching#260winstliu merged 1 commit intoatom:masterfrom MaximSokolov:revert-arguments-matching
winstliu merged 1 commit intoatom:masterfrom
MaximSokolov:revert-arguments-matching
Conversation
To properly tokenize arguments, functions' declarations should be tokenized first
Contributor
Author
|
I checked atom/atom#9655 It seems it shouldn't affect atom core specs, so new version can be released |
Contributor
|
I'll be publishing a new version once I get home. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To properly tokenize arguments, functions' declarations (anything else?) should be tokenized first
Atom specs should be reverted as well...
Ref: #224 (Recognize function bodies)