Funky comment ordering within thread

[kuychaco]

Found a PR that has some funky comment ordering in Atom -- https://github.com/grokys/PullRequestSandbox/pull/23/files

Seems like an edge case, as comment ordering for https://github.com/kuychaco/test-repo/pull/5 appears to be fine.

Upon investigation, the "replyTo" field for the comments is not what I expected / have seen in other comment threads... usually the "replyTo" field always points to the top-level comment ("Comment 1 here." in this case). But we see that most of the comments in this thread actually refer to the comment directly before them.

Not sure when/why this happens... I looked the the pullRequestReview id for each of the comments and it seems that each comment belongs to a different review (as they are all distinct)... this is likely because all of the comments were made as stand-alone comments, and not part of an actual review. Though maybe I'm missing something here 🤔

pullRequestReview ID	Comment body
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzYzMjY4OTQ	Baz
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNjI0MzY	Bar
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNjEzNTU	Foo
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzQzNTIwNzk	Testing
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzM4NTUyODY	Comment 1 here
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NDQwMTc3MzU	Why are there more comments here than on .com?
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzM4NTUyODY	Comment 1 here
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3NTcxNjM3OTU	Inline HTML snippet
MDE3OlB1bGxSZXF1ZXN0UmV2aWV3MzM4NTUyODY	Comment 1 here

[kuychaco]

each comment belongs to a different review (as they are all distinct)... this is likely because all of the comments were made as stand-alone comments, and not part of an actual review

Tested this hypothesis in https://github.com/kuychaco/test-repo/pull/5/files#r254052376

Turns out the standalone comments I made still pointed to the same root review as their "replyTo" comment... so I'm not sure how comments in https://github.com/grokys/PullRequestSandbox/pull/23/files#r112532110 ended up with a "replyTo" id that is different from the root comment 🤔

[smashwilson]

We've changed to using the PullRequest#reviewThreads connection in GraphQL in #1995, which might fix this for us by ✨ magic ✨. But we should at least verify 😄

[kuychaco]

Verified this is fixed in v0.28.0 👍 ✨✨✨