Admit captured property update and delete bytecode#3042
Merged
rogeralsing merged 1 commit intoJun 2, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
Extends the unified bytecode production fast path to admit captured dynamic-identifier bases for first-boundary named/computed property updates and deletes (e.g., () => obj.value++, () => delete obj[key]).
Changes:
- Eligibility: thread
allowsDynamicIdentifiersthroughTryIsFirstBoundaryNamedPropertyDeleteCandidate,TryIsFirstBoundaryComputedPropertyDeleteCandidate, andTryIsFirstBoundaryPropertyUpdateCandidateso dynamic-identifier bases are accepted when admitted. - Compiler: add
TryAppendActivationOrPlainDynamicIdentifierReadValueLoadhelper and route the named/computed property update appenders through it (emittingLoadDynamicIdentifier); plumballowsDynamicIdentifiersinto the computed-key span check. - Tests / docs: new eligibility tests and 8 invocation fast-path tests for arrow + function-expression captured update/delete shapes; expansion contract doc updated for the new admitted surface.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/Asynkron.JsEngine/Execution/UnifiedBytecode/UnifiedBytecodeProductionEligibility.cs | Pass allowsDynamicIdentifiers through update/delete candidate checks. |
| src/Asynkron.JsEngine/Execution/UnifiedBytecode/UnifiedBytecodeCompiler.cs | New helper for activation-or-dynamic-identifier base load; wired into named/computed property update appenders. |
| tests/Asynkron.JsEngine.Tests/UnifiedBytecodeProductionEligibilityTests.cs | Added 4 eligibility acceptance tests for dynamic-identifier-base update/delete shapes. |
| tests/Asynkron.JsEngine.Tests/UnifiedBytecodeProductionInvocationTests.cs | Added 8 fast-path invocation tests covering arrow/function-expression update/delete (named & computed). |
| docs/unified-bytecode-expansion-contract.md | Update date and decline-code descriptions to reflect newly admitted surface. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Proof
Evaluate_NamedPropertyUpdateWithDynamicIdentifierBase_AcceptsWhenDynamicReadsAreAdmitted|FullyQualifiedNameEvaluate_ComputedPropertyUpdateWithDynamicIdentifierBase_AcceptsWhenDynamicReadsAreAdmitted|FullyQualifiedNameEvaluate_NamedPropertyDeleteWithDynamicIdentifierBase_AcceptsWhenDynamicReadsAreAdmitted|FullyQualifiedNameEvaluate_ComputedPropertyDeleteWithDynamicIdentifierBase_AcceptsWhenDynamicReadsAreAdmitted|FullyQualifiedNameArrowFunction_CapturedPropertyUpdateExpression_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameFunctionExpression_CapturedPropertyUpdateExpression_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameArrowFunction_CapturedComputedPropertyUpdateExpression_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameFunctionExpression_CapturedComputedPropertyUpdateExpression_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameArrowFunction_CapturedPropertyDeleteExpression_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameFunctionExpression_CapturedPropertyDeleteExpression_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameArrowFunction_CapturedComputedPropertyDeleteExpression_UsesUnifiedBytecodeProductionFastPath|FullyQualifiedNameFunctionExpression_CapturedComputedPropertyDeleteExpression_UsesUnifiedBytecodeProductionFastPath" — 12 passedExpressionProgramCoverageMapTests&FullyQualifiedNameUnifiedBytecodeExpansionContract_ListsRequiredHeadingsAndCurrentEnums" — 1 passed