fix: clarify support for Boolean JSON Schemas#561
Merged
magicmatatjahu merged 1 commit intoJun 15, 2021
Merged
Conversation
magicmatatjahu
added
the
✏️ Editorial
|
Kudos, SonarCloud Quality Gate passed!
|
derberg
approved these changes
Jun 15, 2021
Contributor
|
🎉 This PR is included in version 2.1.0-2021-06-release.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
|
🎉 This PR is included in version 2.2.0-2021-06-release.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
title: "Mention about true/false JSON Schemas in Schema Object"
As Schema Object in spec is defined as superset of the JSON Schema Specification Draft 07, it would be nice to specify that the Schema Object itself can be boolean value. I know it results from the definition of draft 07, so I'd like to hear your opinion about the changes.
Description for
true/falseschemas I took from https://github.com/OAI/OpenAPI-Specification/pull/2609/files Thanks to @MikeRalphsonRelated issue(s):
asyncapi/parser-js#232
Fixes #554
Related PR(s):
asyncapi/spec-json-schemas#63 - fix bug with true/false schemas in JSON Schema of spec
asyncapi/parser-js#311 - handle true/false JSON Schema in parser
asyncapi/asyncapi-react#367 - handle Boolean JSON Schema in the
react-component