Skip to content

docs: add example for websocket with bindings#533

Merged
derberg merged 2 commits into
asyncapi:masterfrom
derberg:add-websocket-example
May 6, 2021
Merged

docs: add example for websocket with bindings#533
derberg merged 2 commits into
asyncapi:masterfrom
derberg:add-websocket-example

Conversation

@derberg

@derberg derberg commented Apr 30, 2021

Copy link
Copy Markdown
Member

@derberg derberg requested a review from fmvilas April 30, 2021 09:18
fmvilas
fmvilas previously approved these changes May 6, 2021

@fmvilas fmvilas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 💯

@derberg

derberg commented May 6, 2021

Copy link
Copy Markdown
Member Author

@fmvilas please approve again. I fixed server name I noticed during my life stream, left over from my asyncapi file about Shrek app :)

@sonarqubecloud

sonarqubecloud Bot commented May 6, 2021

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@derberg derberg merged commit 0f2bc97 into asyncapi:master May 6, 2021
@derberg derberg deleted the add-websocket-example branch May 6, 2021 12:14
@asyncapi-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg

derberg commented May 24, 2021

Copy link
Copy Markdown
Member Author

It is actually not included in the release. This was an unintentional release caused by the release automation initial run. 1.0 version of the spec was released a long time ago. The release mentioned by the bot was removed.

@derberg derberg removed the released label May 24, 2021
@asyncapi-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@derberg

derberg commented Jun 15, 2021

Copy link
Copy Markdown
Member Author

Not included in release 2.1 yet, 2.1 was mistakenly triggered by our automation.

@asyncapi-bot

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 2.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants