feat: add support for multi-format schema#814
Conversation
smoya
requested review from
asyncapi-bot-eve,
derberg,
fmvilas,
jonaslagoni and
magicmatatjahu
as code owners
magicmatatjahu
left a comment
magicmatatjahu
left a comment
There was a problem hiding this comment.
I won't to request changes to not block you, but I have some comments. Very well! :)
| }); | ||
| }); | ||
|
|
||
| describe('.schemaFormat()', function() { |
There was a problem hiding this comment.
Why remove the tests when we still have the functions? 🤔
There was a problem hiding this comment.
The reality is that message should not have the schemaFormat method but only the MessageTrait. See https://github.com/asyncapi/parser-api/pull/86/files#diff-ac35ac6e0b0ad3629802a0e04076aa18e94da614f5392e1164dcaacdfe3ee198L157
There was a problem hiding this comment.
I think i will need to change the way inheritance is being made atm... Just adding a bit of composition with a intermediate model MessageBase that both Message + MessageTrait extend from.
There was a problem hiding this comment.
After thinking again and again, makes sense to keep schemaFormat + add hasSchemaFormat to messageObject as well so we reduce the BC impact. I applied the changes + changes in parser-api. See asyncapi/parser-api#86 (comment)
There was a problem hiding this comment.
So this test method is back now
| }); | ||
| }); | ||
|
|
||
| describe('.schemaFormat()', function() { |
There was a problem hiding this comment.
Why remove the tests when we still have the functions? 🤔
There was a problem hiding this comment.
The reality is that message should not have the schemaFormat method but only the MessageTrait. See https://github.com/asyncapi/parser-api/pull/86/files#diff-ac35ac6e0b0ad3629802a0e04076aa18e94da614f5392e1164dcaacdfe3ee198L157
smoya
force-pushed
the
feat/multiFormatSchema
branch
from
f8fa397 to
e067a7c
Compare
smoya
force-pushed
the
feat/multiFormatSchema
branch
from
e067a7c to
035486c
Compare
|
@magicmatatjahu @jonaslagoni this is now ready for review again 🙏 |
|
Kudos, SonarCloud Quality Gate passed!
|
There was a problem hiding this comment.
LGTM, @magicmatatjahu do you want to have a look again?
|
Merging, if you have anything @magicmatatjahu it can be addressed afterwards 🙂 |
|
🎉 This PR is included in version 2.1.0-next-major-spec.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 2.2.0-next-major-spec.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
4 participants
Description
This PR adds the required changes for supporting Multi-format schemas.
The API changes are in this
parser-apiPR asyncapi/parser-api#86 waiting to be reviewed.Replaces #785
Related issue(s)
asyncapi/spec#622