feat!: remove messageId() from the Message and MessageTrait objects#102
Merged
Conversation
fmvilas
requested review from
asyncapi-bot-eve,
jonaslagoni and
smoya
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
jonaslagoni
reviewed
Nov 4, 2023
jonaslagoni
approved these changes
Nov 6, 2023
Contributor
Author
|
/rtm |
jonaslagoni
requested changes
Nov 6, 2023
jonaslagoni
left a comment
jonaslagoni
left a comment
Member
There was a problem hiding this comment.
@smoya do we have to manually change the version of the API?
jonaslagoni
approved these changes
Nov 6, 2023
Member
|
/rtm |
Contributor
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
It removes
messageId()from the Message and MessageTrait objects. We already haveid()so it doesn't make sense to have it there anymore.If this changes is accepted and parser-api@3 is released, I'll update the table at https://github.com/asyncapi/parser-js#api-documentation.
Related issue(s)
asyncapi/spec#978