Skip to content

fix(core) astubbs#248: an async commit counts as committed when the broker answers, not when it is sent - #470

Merged
astubbs merged 9 commits into
masterfrom
fix/async-commit-success-waits-for-ack
Sep 8, 2026
Merged

astubbs merged 9 commits into
masterfrom
fix/async-commit-success-waits-for-ack

Merge origin/master into fix/async-commit-success-waits-for-ack

a2d5a18
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 8, 2026 in 1s

82.57% (+0.36%) compared to 745b1f6

View this Pull Request on Codecov

82.57% (+0.36%) compared to 745b1f6

Details

Codecov Report

❌ Patch coverage is 96.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.57%. Comparing base (745b1f6) to head (a2d5a18).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...llelconsumer/internal/ConsumerOffsetCommitter.java 92.30% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #470      +/-   ##
============================================
+ Coverage     82.21%   82.57%   +0.36%     
- Complexity     1537     1551      +14     
============================================
  Files            96       96              
  Lines          5353     5373      +20     
  Branches        533      536       +3     
============================================
+ Hits           4401     4437      +36     
+ Misses          757      739      -18     
- Partials        195      197       +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.