fix(image-page): remove RootDirectory from path to fix doubled path (#30)#31
Merged
Conversation
) BaseSaveDirectory is already an absolute path; prepending RootDirectory via CombinePath (Path.Join) produced doubled paths like /home/user//home/user/Pictures/... causing SKImage.FromEncodedData to return null. Drop RootDirectory from the CombinePath call. Also remove File.Delete on SKImage null (was deleting valid files due to the bad path) and add diagnostic logging for found/not-found cases. Fix FileDetailRepository to use AsAsyncEnumerable().CountAsync to avoid EF Core translation issues. Closes #30 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jbarden
approved these changes
May 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BaseSaveDirectoryis already an absolute path; prependingRootDirectoryviaCombinePath(Path.Join) produced doubled paths like/home/user//home/user/Pictures/...SKImage.FromEncodedDatareturnednullbecause the doubled path did not resolve to a real fileRootDirectoryfrom theCombinePathcall inImagePage.GetImageFromPageFile.Deleteon SKImage null (was incorrectly deleting valid downloaded files due to the bad path)FileDetailRepositoryto useAsAsyncEnumerable().CountAsyncto avoid EF Core translation issuesCloses #30
Test plan
dotnet build)SKImage.FromEncodedDatareturns non-null for downloaded images🤖 Generated with Claude Code