Skip to content

Added components for gatk#206

Merged
PhilPalmer merged 13 commits intodevfrom
lifebit
Jun 18, 2019
Merged

Added components for gatk#206
PhilPalmer merged 13 commits intodevfrom
lifebit

Conversation

@PhilPalmer
Copy link
Collaborator

@PhilPalmer PhilPalmer commented Jun 14, 2019

Hey,

I've added bwa, mark_duplicates, base_recalibrator & haplotype_caller components.

Anyone please review, especially @ODiogoSilva

Things I'm not sure on & you might want to check:

  • For the parameters in the classes is it best to set default to false rather than null?
  • Is there a better solution to ${fasta}.fasta in the templates for base_recalibrator & haplotypecaller?
  • I have added mark_duplicates & base_recalibrator to the mapping class. Would it be better if I made a new one eg read_data_manipulation?

@ODiogoSilva
Copy link
Collaborator

@PhilPalmer

1 - For non-boolean parameters, the falsy value should be null like you provided. false is mostly reserved for boolean parameters.
2 - There may be, but with additional time. For now we can go with a working solution and later optimize.
3 - Placement is fine.

@PhilPalmer PhilPalmer merged commit 0527009 into dev Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants