Repository navigation
ci: bump Redline to askalf/ci@9718a75 - #320
Conversation
sprayberry-redline
left a comment
There was a problem hiding this comment.
Verdict: approve. This updates every referenced askalf/ci action and reusable workflow to the same immutable commit, including the corresponding redline-ref inputs. The workflow permissions, inputs, and execution paths are otherwise unchanged.
sprayberry-redline
left a comment
There was a problem hiding this comment.
Verdict: request changes. The workflow references and redline-ref inputs consistently use the new full commit pin. The added runner-check exception matches marketplace-watch's existing repository-only runner expression, but the PR description incorrectly says the pins are the only change.
1. Blocking: PR description:1
The pins are the only change.
The diff also adds repo-only: fleet-status.yml fleet-status-backfill.yml marketplace-watch.yml to fleet-status-self-test.yml. That changes the runner-expression check's configuration, rather than only updating dependency pins.
Suggested fix:
Update the description to mention the repository-only runner-expression exception for marketplace-watch and remove the claim that only pins change.
rule:misleading-text
sprayberry-redline
left a comment
There was a problem hiding this comment.
Verdict: request changes. The workflow references and redline-ref inputs consistently use the new full commit pin. The added runner-check exception matches marketplace-watch's existing repository-only runner expression, but the PR description incorrectly says the pins are the only change.
1. Blocking: PR description:1
The pins are the only change.
The diff also adds repo-only: fleet-status.yml fleet-status-backfill.yml marketplace-watch.yml to fleet-status-self-test.yml. That changes the runner-expression check's configuration, rather than only updating dependency pins.
Suggested fix:
Update the description to mention the repository-only runner-expression exception for marketplace-watch and remove the claim that only pins change.
rule:misleading-text
Description updated at 93a1a1d
The pull request description is replaced. No file changed. |
sprayberry-redline
left a comment
There was a problem hiding this comment.
Verdict: approve. The workflow calls and redline-ref inputs consistently use the same full commit pin. The self-test's repo-only list matches the three existing repository-based runner expressions, without changing their triggers, permissions, or runner selection.
Moves the pinned askalf/ci calls and their redline-ref inputs, and every askalf/ci action pin (drift-report, checkout-with-retry, fleet-status, fleet-status-check), to askalf/ci@9718a75, the main commit that last changed the review, the fix or an action (main 2026-10-29, askalf/ci#139). The scripts are fetched at that same commit.
Besides the pins, fleet-status-self-test.yml passes a new
repo-onlyinput to fleet-status-check listing fleet-status.yml, fleet-status-backfill.yml and marketplace-watch.yml. Those three workflows pick the runner from the repository alone (github.repository == 'askalf/truecopy') rather than from the pull request's origin, and the input tells the runner-expression check to accept that form for them. No workflow's own behaviour changes.