Skip to content

ci: bump Redline to askalf/ci@9718a75 - #320

Merged
askalf merged 17 commits into
masterfrom
bot/redline-pin
Oct 30, 2026
Merged

askalf merged 17 commits into
masterfrom
bot/redline-pin

Conversation

@askalf

@askalf askalf commented Oct 29, 2026 •

Copy link
Copy Markdown
Owner

Moves the pinned askalf/ci calls and their redline-ref inputs, and every askalf/ci action pin (drift-report, checkout-with-retry, fleet-status, fleet-status-check), to askalf/ci@9718a75, the main commit that last changed the review, the fix or an action (main 2026-10-29, askalf/ci#139). The scripts are fetched at that same commit.

Besides the pins, fleet-status-self-test.yml passes a new repo-only input to fleet-status-check listing fleet-status.yml, fleet-status-backfill.yml and marketplace-watch.yml. Those three workflows pick the runner from the repository alone (github.repository == 'askalf/truecopy') rather than from the pull request's origin, and the input tells the runner-expression check to accept that form for them. No workflow's own behaviour changes.

@github-actions github-actions Bot added github_actions Pull requests that update GitHub Actions code watch Marketplace watch: scanner harness and acceptance ledger size/S 10-49 hand-written lines labels Oct 29, 2026

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: approve. This updates every referenced askalf/ci action and reusable workflow to the same immutable commit, including the corresponding redline-ref inputs. The workflow permissions, inputs, and execution paths are otherwise unchanged.

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: request changes. The workflow references and redline-ref inputs consistently use the new full commit pin. The added runner-check exception matches marketplace-watch's existing repository-only runner expression, but the PR description incorrectly says the pins are the only change.

1. Blocking: PR description:1

The pins are the only change.

The diff also adds repo-only: fleet-status.yml fleet-status-backfill.yml marketplace-watch.yml to fleet-status-self-test.yml. That changes the runner-expression check's configuration, rather than only updating dependency pins.

Suggested fix:

Update the description to mention the repository-only runner-expression exception for marketplace-watch and remove the claim that only pins change.

rule:misleading-text

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: request changes. The workflow references and redline-ref inputs consistently use the new full commit pin. The added runner-check exception matches marketplace-watch's existing repository-only runner expression, but the PR description incorrectly says the pins are the only change.

1. Blocking: PR description:1

The pins are the only change.

The diff also adds repo-only: fleet-status.yml fleet-status-backfill.yml marketplace-watch.yml to fleet-status-self-test.yml. That changes the runner-expression check's configuration, rather than only updating dependency pins.

Suggested fix:

Update the description to mention the repository-only runner-expression exception for marketplace-watch and remove the claim that only pins change.

rule:misleading-text

@askalf

askalf commented Oct 30, 2026

Copy link
Copy Markdown
Owner Author

Description updated at 93a1a1d

  • [1] PR description: I took out the claim that the pins are the only change. A new paragraph covers the repo-only input that fleet-status-self-test.yml now passes to fleet-status-check, which lists fleet-status.yml, fleet-status-backfill.yml and marketplace-watch.yml. Those three workflows pick their runner from the repository alone (github.repository == 'askalf/truecopy'), and the input lets the runner-expression check accept that form for them. No code changed.

The pull request description is replaced.

No file changed.

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: approve. The workflow calls and redline-ref inputs consistently use the same full commit pin. The self-test's repo-only list matches the three existing repository-based runner expressions, without changing their triggers, permissions, or runner selection.

@askalf
askalf merged commit 272e16c into master Oct 30, 2026
30 of 31 checks passed
@askalf
askalf deleted the bot/redline-pin branch October 30, 2026 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code size/S 10-49 hand-written lines watch Marketplace watch: scanner harness and acceptance ledger

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants