Repository navigation
chore: mark the README terminal render as captured output - #315
Merged
Merged
Conversation
.github/readme/terminal.svg is generated by scripts/readme/terminal.mjs from a real run of the CLI, so its text is the CLI's own output (the verify summary prints an em dash, for one). Marking it redline-protected lets the public-text and redline checks skip wording findings on it. The checks read the mark from the base commit, so it has to land before the README change that adds the file.
sprayberry-redline
approved these changes
Oct 29, 2026
sprayberry-redline
left a comment
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: approve. The attribute correctly scopes the captured-output mark to the terminal SVG. One comment should be shortened to describe the file rather than the review-check implementation.
Minor:
.gitattributes:9: This comment narrates review-check behavior instead of documenting the attribute's purpose, so it adds patch-process detail that will become stale and is not useful to users of the file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Marks
.github/readme/terminal.svgasredline-protectedin.gitattributes.The file is captured CLI output:
scripts/readme/terminal.mjsrenders it from a real run of this checkout's CLI, so its text is whatever the CLI prints. The verify summary line, for one, prints an em dash, which the public-text check would otherwise fail on.Both checks read the mark from the base commit, never the head, so this has to merge before the README PR that adds the SVG and its generator. That PR is opened from
docs/readme-world-class; its public-text check gets re-run once this lands.Only
.gitattributeschanges.git check-attr redline-protectedreportssetfor the SVG andunspecifiedfor everything else.