Repository navigation
ci: drop macOS, Windows on Node 22 only, as a non-required check - #260
Merged
Merged
Conversation
The test matrix ran ubuntu, windows and macos on Node 20, 22 and 24: nine jobs. macOS ran nothing Linux does not: CI sets CANON_NO_KEYCHAIN and the keychain tests use the fake, so the macOS security branch never runs. Windows is the only place the Windows-only behaviour runs (the lock guard read as EPERM mid-release, Git Bash paths), which does not vary by Node version, so it keeps one entry on Node 22. Linux keeps 20, 22 and 24. Four jobs instead of nine. The Windows entry runs on GitHub's runners, so it is made non-required in the ruleset: a hosted outage or billing block no longer holds every merge here.
askalf
enabled auto-merge (squash)
October 7, 2026 17:49
sprayberry-redline
approved these changes
Oct 7, 2026
sprayberry-redline
left a comment
Collaborator
There was a problem hiding this comment.
Verdict: approve. The matrix produces three Ubuntu jobs and one Windows job on Node 22 while preserving runner selection and the packed-tarball checks. The contributor guidance matches the intended required checks, subject to the ruleset update explicitly called out before merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
testmatrix ran ubuntu, windows and macos, each on Node 20, 22 and 24: nine jobs. After this it runs four.CANON_NO_KEYCHAIN=1, andkeychain.test.mjsdrives a fake keychain, so the macOS-only branch (securityinsrc/keychain.mjs) never runs in CI.packed tarballjob also keeps its Windows entry.Check names after this:
test (ubuntu-latest, 20),test (ubuntu-latest, 22),test (ubuntu-latest, 24),test (windows-latest, 22).Ruleset (before merge)
The
master protectionruleset requirestest (windows-latest, 20),test (macos-latest, 20)andtest (macos-latest, 22), which this removes, andtest (windows-latest, 22), which becomes optional. All four have to come off the required list before this merges; otherwise every PR waits on checks that never report. Staged for the operator asRUN-ruleset-windows-optional.sh.Tests
node scripts/fleet-status.test.mjs: 180 pass. Its runner checks evaluate the unchangedruns-onexpression.