Skip to content

fleet-status: run on a label event only for the verified label - #159

Merged
askalf merged 1 commit into
mainfrom
fleet-status/label-filter
Nov 2, 2026
Merged

fleet-status: run on a label event only for the verified label#159
askalf merged 1 commit into
mainfrom
fleet-status/label-filter

Conversation

@askalf

@askalf askalf commented Nov 2, 2026

Copy link
Copy Markdown
Owner

The lanes read one label, verified (fleet-status.mjs). Every other labeled/unlabeled event ran a status job that posted nothing new. A Dependabot PR fires two such events as it opens, so a few Dependabot PRs at once queue a dozen status jobs behind the repository's status runner.

  • check.mjs: two new rules on the status job's if::
    • a verified label added or removed runs the job;
    • any other label event does not.
  • Fixture: the if: gains 
    (!contains(fromJSON('["labeled","unlabeled"]'), github.event.action) ||
 github.event.label.name == 'verified')
    on the same-repo pull_request/review branch.
  • check.test.mjs: a break case for each direction, and the fork case updated to the new text. Result: 164 pass, 0 fail.
  • README: the caller sketch mentions the label rule.

Callers move with the pin bump. The new rules fail a caller whose if: lacks the filter, so each caller PR carries both the filter and the pin.

@askalf
fleet-status: run on a label event only for the verified label
1a3eacc 
The lanes read one label, verified. Every other label added or removed
ran a status job that posted nothing new, and a Dependabot PR fires two
such events as it opens, so a few Dependabot PRs at once queued a dozen
status jobs behind the repository's status runner.

The checker now holds the caller's if: to it: a verified label added or
removed runs the job, any other label event does not. The fixture's
if: carries the filter, with a break case for each direction.
sprayberry-redline
sprayberry-redline approved these changes Nov 2, 2026
View reviewed changes

@sprayberry-redline sprayberry-redline left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict: approve. The status-job condition now admits label-triggered runs only when the changed label is verified, while preserving other pull request events. The fixture and break cases exercise both rejecting unrelated label events and accepting verified-label changes.

@askalf
askalf merged commit 84d68a0 into main Nov 2, 2026
13 checks passed
@askalf
askalf deleted the fleet-status/label-filter branch November 2, 2026 02:15
This was referenced Nov 2, 2026
Merged
Merged
Merged
askalf added a commit to askalf/cordon that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#200)
e83122b 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. Moves the askalf/ci pins to 84d68a0 (askalf/ci#159), whose checker requires the filter.
askalf added a commit to askalf/amnesia that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#200)
3387a1b 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. Moves the askalf/ci pins to 84d68a0 (askalf/ci#159), whose checker requires the filter.
askalf added a commit to askalf/homebrew-tap that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#25)
9a76c63 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. Moves the askalf/ci pins to 84d68a0 (askalf/ci#159), whose checker requires the filter.
This was referenced Nov 2, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
askalf added a commit to askalf/pitlane that referenced this pull request Nov 2, 2026
@askalf
ci: bump Redline to askalf/ci@84d68a0 (#6)
4662ca8 
Moves the pinned askalf/ci calls and their redline-ref inputs, and every
askalf/ci action pin (drift-report, checkout-with-retry, fleet-status,
fleet-status-check), to
askalf/ci@84d68a0, the main commit that
last changed the review, the fix or an action (main 2026-11-02,
askalf/ci#159). The scripts are fetched at that same commit. The pins
are the only change.
This was referenced Nov 2, 2026
Merged
Merged
Merged
Merged
Merged
Merged
Merged
askalf added a commit to askalf/askalf that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#201)
b14a14f 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. The askalf/ci pin (84d68a0, askalf/ci#159) already requires this filter, so the self-test fails without it.
askalf added a commit to askalf/truecopy-action that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#121)
3f4c6ce 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. The askalf/ci pin (84d68a0, askalf/ci#159) already requires this filter, so the self-test fails without it.
askalf added a commit to askalf/plumbline that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#145)
7555c3a 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. The askalf/ci pin (84d68a0, askalf/ci#159) already requires this filter, so the self-test fails without it.
askalf added a commit to askalf/redstamp that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#273)
f0bcd7d 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. The askalf/ci pin (84d68a0, askalf/ci#159) already requires this filter, so the self-test fails without it.
askalf added a commit to askalf/truecopy that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#339)
c5379d2 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. The askalf/ci pin (84d68a0, askalf/ci#159) already requires this filter, so the self-test fails without it.
askalf added a commit to askalf/browser-bridge that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#249)
fa08b26 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. The askalf/ci pin (84d68a0, askalf/ci#159) already requires this filter, so the self-test fails without it.
askalf added a commit to askalf/dario that referenced this pull request Nov 2, 2026
@askalf
fleet-status: run on a label event only for the verified label (#1793)
37afbb4 
The lanes read one label, verified; any other label event ran a status job that posted nothing new, and a Dependabot PR fires two as it opens. The askalf/ci pin (84d68a0, askalf/ci#159) already requires this filter, so the self-test fails without it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sprayberry-redline sprayberry-redline sprayberry-redline approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@askalf @sprayberry-redline