Skip to content

Fix auto refresh token logic to ensure timely token renewal #442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NipuniBhagya wants to merge 1 commit into
base: main
Choose a base branch
from
+19 −4
Open

Fix auto refresh token logic to ensure timely token renewal #442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/short-lemons-change.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@asgardeo/browser': patch
---

Fix auto refresh token logic error
18 changes: 14 additions & 4 deletions packages/browser/src/__legacy__/helpers/spa-helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,13 +42,23 @@ export class SPAHelper<T extends MainThreadClientConfig | WebWorkerClientConfig>

const sessionData = await this._storageManager.getSessionData();
if (sessionData.refresh_token) {
// Refresh 10 seconds before the expiry time
const expiryTime = parseInt(sessionData.expires_in);
const time = expiryTime <= 10 ? expiryTime : expiryTime - 10;
if (sessionData.created_at == null || sessionData.expires_in == null) {
return;
}

const TOKEN_REFRESH_BUFFER_MS = 10_000;
const expiryTime = Number(sessionData.expires_in) * 1000;
const absoluteExpiryTime: number = sessionData.created_at + expiryTime;
const timeUntilRefresh = absoluteExpiryTime - Date.now() - TOKEN_REFRESH_BUFFER_MS;

if (timeUntilRefresh <= 0) {
await authenticationHelper.refreshAccessToken();
return;
}

const timer = setTimeout(async () => {
await authenticationHelper.refreshAccessToken();
}, time * 1000);
}, timeUntilRefresh);

await this._storageManager.setTemporaryDataParameter(
TokenConstants.Storage.StorageKeys.REFRESH_TOKEN_TIMER,
Expand Down
Loading