Conversation
Make the source build less shell-fragile by deriving version macros in make, failing header generation when the result is blank, and using portable bash shebangs for the touched scripts. This preserves the current build flow while making it work on FreeBSD hosts that do not ship bash at /bin/bash and that expose the make recipe ordering bug.
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s build/release scripts and sqlite-vec.h generation to behave correctly on FreeBSD (notably where bash is not at /bin/bash), while keeping the overall build/release structure unchanged.
Changes:
- Compute
VERSION_MAJOR/MINOR/PATCHdirectly in theMakefileand pass them into theenvsubst-based header generation. - Add post-generation checks to fail fast if
sqlite-vec.hversion macros are blank/invalid. - Switch touched shell scripts to
#!/usr/bin/env bashand adjust thelinttarget’s shell selection.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| scripts/vendor.sh | Updates shebang to use env bash for FreeBSD compatibility. |
| scripts/publish-release.sh | Updates shebang to use env bash for FreeBSD compatibility. |
| Makefile | Moves version-part parsing into Make variables, validates generated header macros, and adjusts lint shell selection. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| #!/bin/bash | ||
| #!/usr/bin/env bash | ||
|
|
||
| set -euo pipefail xtrace |
There was a problem hiding this comment.
set -euo pipefail xtrace does not enable xtrace; it sets the positional parameters to the literal string xtrace (and can break argument handling if this script ever starts using "$@"/"$1"). Use a proper xtrace flag (e.g., include -x in the set options, or enable xtrace in a separate set -x command).
| set -euo pipefail xtrace | |
| set -euxo pipefail |
| black tests/test-loadable.py | ||
|
|
||
| lint: SHELL:=/bin/bash | ||
| lint: SHELL:=$(shell command -v bash || echo /bin/bash) |
There was a problem hiding this comment.
The lint target picks a bash path via command -v bash || echo /bin/bash. If bash exists but isn't on PATH (or if command -v prints nothing), this will fall back to /bin/bash and fail with a confusing "No such file" error on platforms like FreeBSD where bash is typically in /usr/local/bin. Consider making the target fail fast with a clear error when bash can't be located, rather than defaulting to /bin/bash.
| lint: SHELL:=$(shell command -v bash || echo /bin/bash) | |
| lint: SHELL:=$(or $(shell command -v bash 2>/dev/null),$(error bash is required for the lint target; please install bash and ensure it is on PATH)) |
Summary
This PR makes the touched build scripts and header-generation path work on
FreeBSD without changing the overall release/build structure.
What changed
Makefilesqlite-vec.hgeneration immediately if the version macros are blank#!/usr/bin/env bashWhy this matters
On the validated FreeBSD host:
sqlite-vec.hrecipe could generate blank version macrosbecause it depended on shell assignment ordering
/bin/bashdid not exist, even though bash was installed at/usr/local/bin/bashThe result was a FreeBSD source-build path that failed for reasons unrelated to
sqlite-vec itself.
Validation
Validated on a real FreeBSD 15.0 amd64 host:
gmake clean && rm -f sqlite-vec.h && gmake sqlite-vec.h loadablesqlite3 :memory: ".load ./dist/vec0.so" "select vec_version();"Known limits
Python 3.11 lacks the stdlib
_sqlite3module