Build-Switches: document DOCKER_PRUNE opt-in#920
Conversation
armbian/build now gates Docker image cleanup behind DOCKER_PRUNE=yes (defaulting to off) to avoid a race on hosts where multiple build invocations share one Docker daemon — the typical setup on a server running several self-hosted GitHub Actions runners. Add the switch to the Build-Switches reference next to the other DOCKER_* entries, including a behaviour-change note for users who relied on the automatic reclaim. See: armbian/build#9704
WalkthroughDocumentation was added to Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/Developer-Guide_Build-Switches.md (1)
145-147: ⚡ Quick winConsider breaking up the long explanation for better readability.
Lines 145-147 form a single 200+ character sentence that packs in multiple complex ideas: what the option does, the default rationale, the race condition scenario, the error message, and the use-case recommendation. Breaking this into shorter sentences would improve comprehension.
📝 Suggested rewrite for improved clarity
-Whether the build framework automatically reclaims disk space by removing old Armbian build images during setup. Off by default — safe for hosts where multiple build invocations share one Docker daemon (typical for a server running several self-hosted GitHub Actions runners on the same machine), since concurrent pruning can race with another invocation that is still committing a freshly built image and surface as `failed to get digest sha256:…: no such file or directory`, aborting the in-flight build. - -Set to `yes` on single-host setups where automatic disk reclaim is desirable. +Controls whether the build framework automatically reclaims disk space by removing old Armbian build images during setup. + +The default is `no` to avoid race conditions on hosts where multiple build invocations share one Docker daemon (typical for a server running several self-hosted GitHub Actions runners). Concurrent pruning can race with another invocation that is still committing a freshly built image, causing errors like `failed to get digest sha256:…: no such file or directory` and aborting the in-flight build. + +Set to `yes` on single-host setups where automatic disk reclaim is desirable.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/Developer-Guide_Build-Switches.md` around lines 145 - 147, Split the long paragraph explaining automatic disk reclamation into several short sentences: first state plainly what the option controls (automatic removal of old Armbian build images), then state the default setting (off) and the rationale (safe for hosts where multiple build invocations share one Docker daemon), next describe the race condition scenario and include the example error (`failed to get digest sha256:…: no such file or directory`) as a separate short sentence, and finish with the recommendation for single-host setups (set to `yes` when automatic reclaim is desirable); target the paragraph that begins “Whether the build framework automatically reclaims disk space by removing old Armbian build images during setup...” for this rewrite.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/Developer-Guide_Build-Switches.md`:
- Around line 145-147: Split the long paragraph explaining automatic disk
reclamation into several short sentences: first state plainly what the option
controls (automatic removal of old Armbian build images), then state the default
setting (off) and the rationale (safe for hosts where multiple build invocations
share one Docker daemon), next describe the race condition scenario and include
the example error (`failed to get digest sha256:…: no such file or directory`)
as a separate short sentence, and finish with the recommendation for single-host
setups (set to `yes` when automatic reclaim is desirable); target the paragraph
that begins “Whether the build framework automatically reclaims disk space by
removing old Armbian build images during setup...” for this rewrite.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 553ec111-ac54-4c45-9312-b8de399b7613
📒 Files selected for processing (1)
docs/Developer-Guide_Build-Switches.md
Summary
armbian/build PR #9704 gates the Docker image cleanup behind
DOCKER_PRUNE=yes(default off) to avoid a race on hosts where multiple build invocations share one Docker daemon. This PR documents the new switch inDeveloper-Guide_Build-Switches.mdnext to the existingDOCKER_*entries, with a behaviour-change note for users who relied on the previous automatic reclaim.Requested by @tabrisnet during review of armbian/build#9704.
Test plan
ARMBIAN_DOCKER_AUTO_PULLandCI.Documentation website preview will be available shortly:
Open WWW preview